Skip to content

UI: Show Host OOBM parameter in form if configured#10484

Merged
Pearl1594 merged 3 commits into4.19from
show-configured-oobm
Mar 4, 2025
Merged

UI: Show Host OOBM parameter in form if configured#10484
Pearl1594 merged 3 commits into4.19from
show-configured-oobm

Conversation

@Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented Feb 28, 2025

Description

This PR shows host oobm parameter if is is configured:

image

Post request sent:

image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@Pearl1594
Copy link
Contributor Author

Pearl1594 commented Feb 28, 2025

Comment: #10472 (review) has been address in the this PR @DaanHoogland @kiranchavala.

@Pearl1594 Pearl1594 added this to the 4.19.3 milestone Feb 28, 2025
@codecov
Copy link

codecov bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.16%. Comparing base (f50de89) to head (af7a443).
Report is 4 commits behind head on 4.19.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #10484   +/-   ##
=========================================
  Coverage     15.16%   15.16%           
- Complexity    11329    11332    +3     
=========================================
  Files          5413     5414    +1     
  Lines        474782   474806   +24     
  Branches      57903    57907    +4     
=========================================
+ Hits          72010    72027   +17     
- Misses       394722   394727    +5     
- Partials       8050     8052    +2
Flag Coverage Δ
uitests 4.28% <ø> (-0.01%) ⬇️
unittests 15.89% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bernardodemarco
Copy link
Member

bernardodemarco commented Mar 1, 2025

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Mar 1, 2025

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 1, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10484 (QA-JID-564)

bernardodemarco
bernardodemarco reviewed Mar 1, 2025
View reviewed changes
Copy link
Member

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in the QA environment, looks good.

@Pearl1594, after the OOBM settings are changed, if the user selects the option to configure it again, the new settings are not retrieved. We could add an API call to retrieve the latest OOBM settings, what do you think?

2025-03-01.16-04-34.mp4

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@yadvr yadvr modified the milestones: 4.19.3, 4.20.1 Mar 4, 2025
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Mar 4, 2025

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Mar 4, 2025

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 4, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10484 (QA-JID-568)

DaanHoogland
DaanHoogland approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, verified in qa

bernardodemarco
bernardodemarco approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested in the QA environment

@Pearl1594 Pearl1594 merged commit b41acf2 into 4.19 Mar 4, 2025
49 of 50 checks passed
@Pearl1594 Pearl1594 deleted the show-configured-oobm branch March 4, 2025 11:43
@Pearl1594 Pearl1594 moved this to Done in ACS 4.20.1 Mar 17, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@Pearl1594 @dhslove
UI: Show Host OOBM parameter in form if configured (apache#10484)
6ce0462 
* UI: Show Host OOBM parameter in form if configured

* remove password display

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@bernardodemarco bernardodemarco bernardodemarco approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

@kiranchavala kiranchavala Awaiting requested review from kiranchavala

Assignees

No one assigned

Labels

component:UI status:ready-for-merge

Projects

ACS 4.20.1
Status: Done

Milestone

4.20.1

Development

Successfully merging this pull request may close these issues.

5 participants

@Pearl1594 @bernardodemarco @blueorangutan @DaanHoogland @yadvr